Skip to content

feat(fracmanager): implement fraction snapshots with wait group reference counting#277

Merged
eguguchkin merged 4 commits into
mainfrom
275-fractions-snapshot
Jun 8, 2026
Merged

feat(fracmanager): implement fraction snapshots with wait group reference counting#277
eguguchkin merged 4 commits into
mainfrom
275-fractions-snapshot

Conversation

@eguguchkin

@eguguchkin eguguchkin commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Fixes #275

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@eguguchkin eguguchkin marked this pull request as draft November 24, 2025 15:07
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch 4 times, most recently from d7cfd54 to 6edb32d Compare November 25, 2025 08:16
@eguguchkin eguguchkin force-pushed the 156-new-lifecycle-manager branch 3 times, most recently from 79ea9fe to 4054ad1 Compare January 16, 2026 15:08
Base automatically changed from 156-new-lifecycle-manager to main January 16, 2026 15:46
@eguguchkin eguguchkin marked this pull request as ready for review January 19, 2026 10:08
@eguguchkin eguguchkin modified the milestone: v0.67.0 Jan 26, 2026
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from 6edb32d to 38a7993 Compare January 27, 2026 14:30
@codecov-commenter

codecov-commenter commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.39196% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.73%. Comparing base (985c744) to head (75b4e33).

Files with missing lines Patch % Lines
fracmanager/fraction_registry.go 76.19% 27 Missing and 3 partials ⚠️
util/min_heap.go 73.58% 12 Missing and 2 partials ⚠️
fracmanager/partitioned_collection.go 74.46% 8 Missing and 4 partials ⚠️
fracmanager/lifecycle_manager.go 64.51% 10 Missing and 1 partial ⚠️
fracmanager/sync_appender.go 75.67% 6 Missing and 3 partials ⚠️
fracmanager/fractions_snapshot.go 90.00% 4 Missing and 1 partial ⚠️
asyncsearcher/async_searcher.go 84.61% 1 Missing and 1 partial ⚠️
skipmaskmanager/skip_mask_manager.go 75.00% 0 Missing and 2 partials ⚠️
fracmanager/fracmanager.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   70.66%   70.73%   +0.07%     
==========================================
  Files         222      225       +3     
  Lines       17441    17487      +46     
==========================================
+ Hits        12324    12370      +46     
+ Misses       4195     4192       -3     
- Partials      922      925       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/small-4 174405 3d34b5
10280.15 MB/s 7073.38 MB/s 0.69 🔴
24.90 ns/op 36.19 ns/op 1.45 🔴
GenerateDocs-4 174405 3d34b5
952.20 ns/op 1142.00 ns/op 1.20 🔴

@dkharms dkharms requested review from cheb0 and forshev February 2, 2026 11:03
cheb0
cheb0 reviewed Feb 19, 2026
View reviewed changes
Comment thread storeapi/grpc_search.go Outdated
Comment thread fracmanager/fractions_snapshot.go Outdated
Comment thread fracmanager/fraction_registry.go Outdated
@eguguchkin eguguchkin marked this pull request as draft March 16, 2026 10:24
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch 6 times, most recently from bca9e73 to e4ad14d Compare March 30, 2026 18:49
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
MutexListAppend-4 5115f7 2f35a2
196.07 MB/s 168.49 MB/s 0.86 🔴
83287562.00 ns/op 94961642.00 ns/op 1.14 🔴

@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from e4ad14d to 33b8456 Compare March 30, 2026 19:00
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from 33b8456 to 3ce18ca Compare April 1, 2026 14:06
@dkharms dkharms mentioned this pull request Apr 7, 2026
Merged
2 tasks
dkharms
dkharms approved these changes May 13, 2026
View reviewed changes
Comment thread fracmanager/fracs_stats.go
Comment thread util/min_heap.go
Comment thread util/min_heap.go Outdated
Comment thread util/min_heap.go Outdated
Comment thread storeapi/grpc_v1.go Outdated
Comment thread storeapi/grpc_async_search.go Outdated
Comment thread fracmanager/sync_appender.go
Comment thread fracmanager/sync_appender.go Outdated
@eguguchkin eguguchkin requested a review from cheb0 May 15, 2026 00:05
@dkharms dkharms mentioned this pull request May 15, 2026
Merged
2 tasks
@eguguchkin eguguchkin marked this pull request as ready for review May 18, 2026 09:57
@eguguchkin eguguchkin added this to the v0.73.0 milestone May 18, 2026
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from 3ce18ca to c092251 Compare May 20, 2026 09:28
@eguguchkin eguguchkin removed the request for review from forshev May 20, 2026 12:13
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from e447d7f to 8335b37 Compare June 2, 2026 17:07
@eguguchkin eguguchkin modified the milestones: v0.73.0, v0.72.0 Jun 2, 2026
cheb0
cheb0 approved these changes Jun 5, 2026
View reviewed changes
Comment thread fracmanager/partitioned_collection.go Outdated
Comment thread fracmanager/partitioned_collection.go
Comment thread storeapi/grpc_search.go
@eguguchkin eguguchkin modified the milestones: v0.73.0, v0.72.0 Jun 8, 2026
@eguguchkin eguguchkin force-pushed the 275-fractions-snapshot branch from b3f54cd to 8dd3663 Compare June 8, 2026 20:45
@eguguchkin eguguchkin merged commit bcaaf48 into main Jun 8, 2026
8 checks passed
@eguguchkin eguguchkin deleted the 275-fractions-snapshot branch June 8, 2026 21:26
@eguguchkin eguguchkin modified the milestones: v0.72.0, v0.73.0 Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkharms dkharms dkharms approved these changes

@cheb0 cheb0 cheb0 approved these changes

Assignees

No one assigned

Labels

epic/compaction

Projects

None yet

Milestone

v0.73.0

Development

Successfully merging this pull request may close these issues.

Refactoring Fraction Lifecycle Management System

4 participants

@eguguchkin @codecov-commenter @dkharms @cheb0